-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): Propagate non-job request exceptions to foreground #2382
Open
balamurali27
wants to merge
8
commits into
master
Choose a base branch
from
agent-req-fg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For requests that aren't jobs, it's easier to debug the cause if they are propagated to frontend rather than logged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 38.34% 38.32% -0.02%
==========================================
Files 378 378
Lines 29543 29545 +2
==========================================
- Hits 11328 11323 -5
- Misses 18215 18222 +7 ☔ View full report in Codecov by Sentry. |
balamurali27
force-pushed
the
agent-req-fg
branch
from
December 23, 2024 09:00
13f9663
to
62beb44
Compare
balamurali27
changed the title
fix(Agent): Propagate non-job request exceptions to foreground
fix(agent): Propagate non-job request exceptions to foreground
Jan 2, 2025
balamurali27
force-pushed
the
agent-req-fg
branch
from
January 9, 2025 16:30
c7f811e
to
7b14e8e
Compare
Otherwise requests that fail due to validation error (eg: bench not exists) may block server when attempted multiple times
All variable values are logged in traceback now anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For requests that aren't jobs, it's easier to debug the cause if they are propagated to frontend rather than logged.
Like so:
This PR does 3 things:
Eg: Login as admin
ref: https://support.frappe.io/helpdesk/tickets/27474 was failing due to journeys app. Had to ssh and run the command to see what the issue was. Another case: https://support.frappe.io/helpdesk/tickets/27477
Needs frappe/agent#149 for nicely formatted output as in image