Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invoice item descriptions for missing document types #2380

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

shadrak98
Copy link
Contributor

Item descriptions were only set for Site document type and set as Prepaid credits implicitly in the print format for all others which would make the invoice look something like this

image

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.88%. Comparing base (b5dd9c0) to head (76a3b52).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
press/press/doctype/invoice/invoice.py 35.71% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2380   +/-   ##
=======================================
  Coverage   38.88%   38.88%           
=======================================
  Files         381      381           
  Lines       29396    29406   +10     
=======================================
+ Hits        11430    11435    +5     
- Misses      17966    17971    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadrak98 shadrak98 merged commit b95b2e8 into frappe:master Dec 21, 2024
6 of 7 checks passed
@shadrak98 shadrak98 deleted the fix-inv-item-descs branch December 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant