Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log browser #2282

Merged
merged 10 commits into from
Nov 28, 2024
Merged

feat: log browser #2282

merged 10 commits into from
Nov 28, 2024

Conversation

BreadGenie
Copy link
Member

@BreadGenie BreadGenie commented Nov 14, 2024

agent: frappe/agent#143 (will do this later on as there are some perf issues with it)

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 2.15827% with 136 lines in your changes missing coverage. Please review.

Project coverage is 39.51%. Comparing base (6b2f07f) to head (f43d9ba).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
press/api/log_browser.py 0.00% 135 Missing ⚠️
press/press/doctype/bench/bench.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
- Coverage   39.65%   39.51%   -0.15%     
==========================================
  Files         375      376       +1     
  Lines       28610    28674      +64     
==========================================
- Hits        11345    11330      -15     
- Misses      17265    17344      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BreadGenie BreadGenie marked this pull request as ready for review November 28, 2024 05:20
@adityahase
Copy link
Member

Based on the video in https://gameplan.frappe.cloud/g/frappe-cloud/projects/17/discussion/3210/log-browser-updates

  • The columns jump around when you switch log levels
  • Timestamps look weirdly aligned. Could a monospace font help?

@BreadGenie BreadGenie merged commit 6e10be9 into master Nov 28, 2024
6 of 7 checks passed
@BreadGenie BreadGenie deleted the log-browser branch November 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants