Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database query editor #2217

Merged
merged 54 commits into from
Oct 24, 2024
Merged

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Oct 15, 2024

Related #2178

  • Database Schema Browser
    • Show indexes
  • SQL Playground
    • Playground
    • Read-only / Read-write mode
    • SQL Playground UI
      • Result Table
      • SQL Code Editor [code-mirror]
      • Autocompletion table name, column name while writing query [?]
      • SQL Playground Log modal
      • Download result in CSV
    • SQL Playground Log (Kind of activity log)
    • DDL Query Support
    • Add support for multiline query
    • Show no of rows affected from DDL/DQL query.
  • [ ] Testcases Testcases added on the agent side, as on the press end there are very few functions and required active agent with proper setup to do the testss.

Preview

Screen.Recording.2024-10-23.at.1.54.34.PM.mov

Agent PR - frappe/agent#135


Note -
Currently, this feature is available to desk users. Will remove the restrictions in next PR after test.
Released for all users.

@tanmoysrt tanmoysrt mentioned this pull request Oct 15, 2024
5 tasks
@tanmoysrt tanmoysrt added the WIP Work In Progress label Oct 15, 2024
@tanmoysrt tanmoysrt mentioned this pull request Oct 16, 2024
11 tasks
@tanmoysrt tanmoysrt changed the title feat: database editor feat: database query editor Oct 18, 2024
@tanmoysrt tanmoysrt removed the WIP Work In Progress label Oct 23, 2024
@tanmoysrt tanmoysrt marked this pull request as ready for review October 23, 2024 08:32
@tanmoysrt tanmoysrt self-assigned this Oct 23, 2024
@raugustos1
Copy link

awesome

@tanmoysrt tanmoysrt merged commit 43199f0 into frappe:master Oct 24, 2024
4 checks passed
@tanmoysrt tanmoysrt deleted the implement_db_editor branch October 24, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants