fix(snapshots): Delete redundant snapshot entries

We were accidentally creating multiple snapshot documents.
This was fixed with 37d240f63 fix(snapshots): Don't create redundant snapshot entries

This will drop the old records that are still around. And prevent it from happening again.

press/press/doctype/virtual_disk_snapshot/virtual_disk_snapshot.py

@@ -184,6 +184,7 @@ def sync_all_snapshots_from_aws():
 				if _should_skip_snapshot(snapshot):
 					continue
 				try:
+					delete_duplicate_snapshot_docs(snapshot)
 					if _update_snapshot_if_exists(snapshot, random_snapshot):
 						continue
 					tag_name = next(tag["Value"] for tag in snapshot["Tags"] if tag["Key"] == "Name")
@@ -238,6 +239,23 @@ def _should_skip_snapshot(snapshot):
 	return False
 
 
+def delete_duplicate_snapshot_docs(snapshot):
+	# Delete all except one snapshot document
+	# It doesn't matter which one we keep
+	snapshot_id = snapshot["SnapshotId"]
+	snapshot_count = frappe.db.count("Virtual Disk Snapshot", {"snapshot_id": snapshot_id})
+	if snapshot_count > 1:
+		frappe.db.sql(
+			"""
+				DELETE 
+				FROM `tabVirtual Disk Snapshot` 
+				WHERE snapshot_id=%s 
+				LIMIT %s
+			""",
+			(snapshot_id, snapshot_count - 1),
+		)
+
+
 def _update_snapshot_if_exists(snapshot, random_snapshot):
 	snapshot_id = snapshot["SnapshotId"]
 	if frappe.db.exists("Virtual Disk Snapshot", {"snapshot_id": snapshot_id}):