Merge pull request #1105 from pateljannat/issues-48

fix: show only courses with evaluator for batch evaluation
frappe · Nov 8, 2024 · c5f091f · c5f091f
2 parents 3ea52a4 + 4e61d56
commit c5f091f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/frontend/src/components/Modals/EvaluationModal.vue b/frontend/src/components/Modals/EvaluationModal.vue
@@ -154,10 +154,12 @@ function submitEvaluation(close) {
 const getCourses = () => {
 	let courses = []
 	for (const course of props.courses) {
-		courses.push({
-			label: course.title,
-			value: course.course,
-		})
+		if (course.evaluator) {
+			courses.push({
+				label: course.title,
+				value: course.course,
+			})
+		}
 	}
 	return courses
 }

diff --git a/frontend/src/pages/BatchForm.vue b/frontend/src/pages/BatchForm.vue
@@ -83,6 +83,7 @@
 				v-model="instructors"
 				doctype="User"
 				:label="__('Instructors')"
+				:filters="{ ignore_user_type: 1 }"
 			/>
 			<div class="mb-4">
 				<FormControl

diff --git a/frontend/src/pages/CourseForm.vue b/frontend/src/pages/CourseForm.vue
@@ -152,6 +152,7 @@
 							v-model="instructors"
 							doctype="User"
 							:label="__('Instructors')"
+							:filters="{ ignore_user_type: 1 }"
 							:required="true"
 						/>
 					</div>

diff --git a/lms/lms/utils.py b/lms/lms/utils.py
@@ -1103,7 +1103,7 @@ def get_categorized_courses(courses):
 
 		categories = [live, enrolled, created]
 		for category in categories:
-			category.sort(key=lambda x: x.enrollments, reverse=True)
+			category.sort(key=lambda x: cint(x.enrollments), reverse=True)
 
 		live.sort(key=lambda x: x.featured, reverse=True)
 
@@ -1265,7 +1265,7 @@ def get_batch_details(batch):
 	batch_details.instructors = get_instructors(batch)
 
 	batch_details.courses = frappe.get_all(
-		"Batch Course", filters={"parent": batch}, fields=["course", "title"]
+		"Batch Course", filters={"parent": batch}, fields=["course", "title", "evaluator"]
 	)
 	batch_details.students = frappe.get_all(
 		"Batch Student", {"parent": batch}, pluck="student"