Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid continue loop #1584

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

jmishra01
Copy link
Contributor

I found that there is no need to check is_bench multiple times if it's become false.

What type of a PR is this?

  • Changes to Existing Features
  • New Feature Submissions
  • Bug Fix
  • Breaking Change (include change in API behaviours, etc.)

Please provide enough information so that others can review your pull request:


Explain the details for making this change. What existing problem does the pull request solve? The following checklist could help

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally prior to submission?
  • Have you successfully run tests with your changes locally?
  • Does your commit message have an explanation for your changes and why you'd like us to include them?
  • Docs have been added / updated
  • Tests for the changes have been added (for bug fixes / features)
  • Did you modify the existing test cases? If yes, why?

Screenshots/GIFs

Copy link

sonarcloud bot commented Sep 23, 2024

@gavindsouza gavindsouza merged commit af8ed34 into frappe:develop Oct 24, 2024
11 checks passed
Copy link

🎉 This PR is included in version 5.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants