Skip to content

Commit

Permalink
chore: remove proxy method: setup_details_from_git_url (#1546)
Browse files Browse the repository at this point in the history
  • Loading branch information
ssiyad authored Mar 10, 2024
1 parent b12ac64 commit d728b80
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions bench/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def setup_details(self):
# fetch meta for repo from remote git server - traditional get-app url
elif is_git_url(self.name):
self.is_url = True
self._setup_details_from_git_url()
self.__setup_details_from_git()

# fetch meta from new styled name tags & first party apps on github
else:
Expand All @@ -116,7 +116,7 @@ def _setup_details_from_mounted_disk(self):
# If app is a git repo
self.git_repo = git.Repo(self.mount_path)
try:
self._setup_details_from_git_url(self.git_repo.remotes[0].url)
self.__setup_details_from_git(self.git_repo.remotes[0].url)
if not (self.branch or self.tag):
self.tag = self.branch = self.git_repo.active_branch.name
except IndexError:
Expand All @@ -131,9 +131,6 @@ def _setup_details_from_name_tag(self):
self.org, self.repo, self.tag = fetch_details_from_tag(self.name, using_cached)
self.tag = self.tag or self.branch

def _setup_details_from_git_url(self, url=None):
return self.__setup_details_from_git(url)

def __setup_details_from_git(self, url=None):
name = url if url else self.name
if name.startswith("git@") or name.startswith("ssh://"):
Expand Down

0 comments on commit d728b80

Please sign in to comment.