Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing notifiers to scalingo_alert #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mickaelalibert
Copy link

Hello, this PR is a small improvement suggestion :

The scalingo_alert table doesn't contain the notifiers id list, but this information is available via the Scalingo API.

Even though the documentation states that the notifiers information is only available while listing all alerts, I found out that the scalingo client also returns the notifiers while fetching a specific alert via its id.

@mickaelalibert
Copy link
Author

Seems that the reason why I was able to fetch notifiers in a specific scalingo_alert get is that the result was cached from my previous list query.
So the scalingo client is doing exactly as the documentation states, and it is not yet possible to fetch notifiers info on a specific alert. 😞

@francois2metz
Copy link
Owner

I'm keeping it open, maybe Scalingo will return the notifiers on a single result.

@mickaelalibert
Copy link
Author

Scalingo confirmed that they are working on it as this was not the expected functionality.
I'll keep this PR updated when Scalingo applies the patch to its API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants