Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translate the English terms in URLs to Dutch language #899

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: translate the English terms in URLs to Dutch language #899

wants to merge 2 commits into from

Conversation

AliKdhim87
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cms-frameless-io ❌ Failed (Inspect) Sep 17, 2024 7:13am
tiptap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 7:13am

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.27586% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/pdc-frontend/src/util/buildURL.ts 98.13% 2 Missing ⚠️
Files with missing lines Coverage Δ
apps/pdc-frontend/src/util/getStrapiGraphqlURL.ts 100.00% <100.00%> (ø)
apps/pdc-frontend/src/util/buildURL.ts 98.13% <98.13%> (ø)

Robbert
Robbert requested changes Sep 10, 2024
View reviewed changes
apps/pdc-frontend/src/components/SearchBar/index.tsx Outdated
@@ -62,11 +64,15 @@ export const SearchBar: React.FC<SearchBarProps> = ({
}
};

const searchSegment = t('segments.search', {
defaultValue: 'zoeken',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zou je de URL segment strings willen verzamelen in één file, of één file per locale, en importeren? import { SearchSegment } from 'UrlSegmentNL;`

Als je voor de URL utility functions kiest, dan moet het misschien net iets anders werken.

apps/pdc-frontend/src/app/[locale]/(rootLayout)/page.tsx Outdated
@@ -79,7 +85,7 @@ const Home = async ({ params: { locale } }: { params: any }) => {
return {
char: letter,
disabled: !isAvailable,
href: !isAvailable ? undefined : `products/alphabet/${letter.toLocaleLowerCase()}`,
href: !isAvailable ? undefined : `${productsSegment}/${alphabetSegment}/${letter.toLocaleLowerCase()}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat zou je er van denken om een file te hebben met utility functions om URLs te genereren? Uiteindelijk zouden we die kunnen delen tussen pdc-dashboard en pdc-frontend.

Bijvoorbeeld: createProductUrl({ locale: 'en', product: 'klacht' }).

Eventueel met base URL argument zoals new URL(url, base):

createProductUrl({ locale: 'en', product: 'klacht' }, process.env.PDC_FRONTEND_URL)

@AliKdhim87 AliKdhim87 linked an issue Sep 23, 2024 that may be closed by this pull request
Engelse termen in URL's #702
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert Robbert Awaiting requested review from Robbert

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engelse termen in URL's
2 participants
@AliKdhim87 @Robbert