Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): use mirror for black to use mypyc wheels #434

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Jun 28, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

black releases wheels compiled with mypyc, which are faster, but by using pre-commit, we are forced to build wheels, and they are not compiled with mypyc. A mirror was recently created by one of black's maintainers, which uses a similar technic as https://github.com/pre-commit/mirrors-mypy to use mypyc-compiled wheels, making black through pre-commit faster.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #434 (c4f3a9b) into main (b044976) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #434   +/-   ##
=====================================
  Coverage   90.4%   90.4%           
=====================================
  Files         39      39           
  Lines       1084    1084           
  Branches     220     220           
=====================================
  Hits         980     980           
  Misses        89      89           
  Partials      15      15           

@mkniewallner mkniewallner merged commit dca772a into fpgmaas:main Aug 2, 2023
@mkniewallner mkniewallner deleted the chore/use-mirror-black branch March 6, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant