add limited support for zip output (no encryption yet) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
reviewed
Jun 13, 2023
cecinestpasunepipe
requested changes
Jul 14, 2023
|
Dear all, I replaced pyzipper by zipfile |
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 44.34% 44.07% -0.27%
==========================================
Files 22 23 +1
Lines 2783 2834 +51
==========================================
+ Hits 1234 1249 +15
- Misses 1549 1585 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Schamper
requested changes
Sep 19, 2023
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
…uire into feature/zip-output
Schamper
requested changes
Sep 22, 2023
Co-authored-by: Erik Schamper <[email protected]>
|
Hey @janstarke! First of all, thank for this contribution. It looks like the current implementation does not play nice with the acquisition of files in |
Horofic
requested changes
Oct 3, 2023
Co-authored-by: Stefan de Reuver <[email protected]>
Co-authored-by: Stefan de Reuver <[email protected]>
Horofic
reviewed
Oct 4, 2023
Co-authored-by: Stefan de Reuver <[email protected]>
Horofic
previously approved these changes
Oct 5, 2023
Co-authored-by: Erik Schamper <[email protected]>
Co-authored-by: Erik Schamper <[email protected]>
Schamper
approved these changes
Oct 5, 2023
cecinestpasunepipe
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.