Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeout to the os.read function in VolatileStream #205

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Miauwkeru
Copy link
Contributor

No description provided.

@Miauwkeru Miauwkeru requested a review from pyrco November 25, 2024 14:03
@Miauwkeru Miauwkeru force-pushed the dis-3245_volatile-stream-hangs branch from 9f90afa to 4e37058 Compare November 25, 2024 14:03
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.38%. Comparing base (ef2e3d1) to head (4e37058).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/volatilestream.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   47.18%   47.38%   +0.20%     
==========================================
  Files          26       26              
  Lines        3423     3438      +15     
==========================================
+ Hits         1615     1629      +14     
- Misses       1808     1809       +1     
Flag Coverage Δ
unittests 47.38% <82.35%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru merged commit c284e87 into main Nov 26, 2024
16 of 20 checks passed
@Miauwkeru Miauwkeru deleted the dis-3245_volatile-stream-hangs branch November 26, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants