Fix Kashrishi climbing feats #17114
Open
Fix Kashrishi climbing feats #17114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, rather than type. Also made skilled climber change climb speed to movement speed when scuttle up is taken.
packs/feats/skilled-climber.json
Outdated
Comment on lines
37
to
43
| { | ||
| "key": "BaseSpeed", | ||
| "predicate": [ | ||
| "feat:scuttle-up" | ||
| ], | ||
| "selector": "climb", | ||
| "value": "@actor.attributes.speed.total" |
There was a problem hiding this comment.
This will need a toggle since it only applies when "climbing trees or cavern walls". I recommend you use a toggleable roll option predicated on feat:scuttle-up and then predicate this BaseSpeed on just that toggle.
There was a problem hiding this comment.
Just committed a change for that
|
PR titles should be in imperative case, starting with a capital letter and finishing the sentence |
| }, | ||
| { | ||
| "key": "RollOption", | ||
| "label": "Climbing Cavern Wall Or Tree", |
There was a problem hiding this comment.
Please localize this in re-en.json, likely under something like PF2E.SpecificRule.Kashrishi.SkilledClimber.ClimbToggle
We try to keep plain text in rule elements as localization strings only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed kashrishi's scuttle-up and skilled climber feats to use selector, rather than type. Also made skilled climber change climb speed to movement speed when scuttle up is taken.