Check for wall collision when determining flanking buddies in TokenPF2e#isFlanking

[In3luki]

[xyzzy42]

The wall collision check here is different than the one used for the aura to square wall collision check, in this function

pf2e/src/module/canvas/token/aura/util.ts

Line 7 in 498dd94

export function getAreaSquares(data: GetAreaSquaresParams): EffectAreaSquare[] {

The way that code works, is it creates four source points, each offset in one of the cardinal directions from the center of token by ⅛ the token size. Then it checks for any of those points having an unblocked line to the center of the destination square. So it's just four checks, rather than sixteen.

[In3luki]

I totally forgot about this PR. The reason for the 16 tests was to catch edge cases like this:

Ideally it would just be a check if the flanked token is actually rendered on the canvas from the perspective of the flanker but sadly that's not currently possible without switching the canvas perception layer (or maybe it was some other layer that I forgot).