Client optional health port configuration #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Scoropan <[email protected]>
|
Just realized there was still a piece that I'm missing so I updated the PR to draft for the meantime |
|
Closing due to sufficient fix provided part of #220, we can open follow up issues if we want to make further configuration improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for resolving #225 , which is resulting from detectors now using 8001 for health check while still using 8000 for the main port.
This PR enables health ports to be optionally configured as part of the
serviceof a client in the orchestrator config. If omitted, the health port will default to the value of the main port for that client (which itself may default). Alongside adding this, the PR does a minor refactor of how the service configs are passed down, since there is currently complexity in the orchestrator for client creation that could have been caught earlier as part of config loading/validation.(Note that as a follow up to this, we can also be resolving client tls cert paths before client creation, but that is outside the scope of this PR.)