Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token): call sys.exit if server is not reachable #125

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

deveaud-m
Copy link
Collaborator

Properly test all reponse scenarios
Closes #122

Properly test all reponse scenarios
Closes #122
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc2a29c) 92.73% compared to head (899c006) 92.74%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   92.73%   92.74%           
=======================================
  Files          15       15           
  Lines        1694     1695    +1     
=======================================
+ Hits         1571     1572    +1     
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deveaud-m
Copy link
Collaborator Author

@alpianon thanks for the very valuable input in this project's issue tracker

Does this mitigate the problem you've been reporting in #122?

The exit path was indeed not properly tested, I added a dedicated testcase.

@deveaud-m deveaud-m merged commit f8908ee into main Feb 15, 2024
5 checks passed
@deveaud-m deveaud-m deleted the fix/sys-exit branch February 15, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'exit' is not defined
1 participant