tinystdio:fixing hexadecimal string conversion #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an extra else if condition to make sure that the exp is calulated correctly when the exp_match is 'e' The hexadecimal string with decimal points was handled in a wrong way when it was passed to these functions strod(), strtof() and strtold(). The exp variable was only handled when the exp_match is equal to 'p' or 'e', so when any other hexadecimal string with no e or p format specifiers is passed, wrong results returned. therefore the change was made so the exp is handled correctly in all cases not only when p or e are passed as format specifiers. added a new testing value in the file test-strtod.c to test the mentioned case above. Signed-off-by: Hana Ashour <[email protected]>
|
Nice bug report! I've simplified your proposed patch to perform the hex value adjustment entirely so that it was applied for all cases where there wasn't a complete exponent -- "0x0.1p" for instance. I'll see about adjusting the test so we can check those cases as well. Check out https://github.com/picolibc/picolibc/tree/keithp_hex_conversion and see what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hexadecimal string with decimal points was handled in a wrong way when it was passed to these functions strod(), strtof() and strtold(). The exp variable was only handled when the exp_match is equal to 'p' or 'e', so when any other hexadecimal string with no e or p format specifiers is passed, wrong results returned. therefore the change was made so the exp is handled correctly in all cases not only when p or e are passed as format specifiers.
added a new testing value in the file test-strtod.c to test the mentioned case above.
line 59 in the file test-strtod.c, shows that without this change there is an issue if the hexadecimal input has no e or p format specifiers.