Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test that setup-fpm passes all the fpm tests #24

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Sep 18, 2024

Fixes #9

I thought it would be quite appropriate (and somewhat funny) to check that fpm-setup works by running the fpm test suite.

Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@gnikit
Copy link
Member Author

gnikit commented Sep 18, 2024

@everythingfunctional we might want to enable the fortran-setup only for macos where things are failing without it, because Linux and Windows are super slow to install also I get warning for the Windows setup for the compiler+version not being recognised (which we should be getting). I suspect that this is a fortran-setup bug though.

@everythingfunctional
Copy link
Member

@gnikit , depends how confident you are that things will continue to work on Linux and Windows without it.

@gnikit
Copy link
Member Author

gnikit commented Sep 18, 2024

@gnikit , depends how confident you are that things will continue to work on Linux and Windows without it.

Good point, confidence level should be low. So I'll merge and we'll take the CI runtime hit for now, until I setup caching for the compilers in setup-fortran.

@gnikit gnikit merged commit 3a4b939 into main Sep 18, 2024
9 checks passed
@gnikit gnikit deleted the ci/check-fpm-works branch September 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have Action Verify Installed fpm Works
2 participants