Group 2: Refactoring and documentation of ImportCSV.java #19
Conversation
| } | ||
| } | ||
|
|
||
| for (Pet p : petsToAdd) { |
There was a problem hiding this comment.
nice to also see such a solution ... you are the first ones so far that moved this functionality to end if all pets can be parsed...
it can get a bit tricky then to keep the same order of execution as intended by the original csv
| * @param dateOfBirth | ||
| * @return SettingResponse | ||
| */ | ||
| private SettingResponse setDateOfBirth(Pet pet, String dateOfBirth) { |
There was a problem hiding this comment.
I like that you extracted and created this and the below functions, which fulfill one single purpose, are small and you also kept the indentations small :)
| // the method has to renamed - it doesn't just import, it also deletes | ||
| List<Pet> petsToAdd = new LinkedList<>(); | ||
| List<Pet> petsToDelete = new LinkedList<>(); | ||
| for (String line : csv.split("\\r?\\n")) { |
There was a problem hiding this comment.
you could think about extracting the most contents of importPets to a new method, so importPets is only responsible about handling the request and the new method takes care of orchestrating the parsing and so on (probably you would have done this with more time :) )
No description provided.