Group #5 #36
Open
Group #5 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejavu9127
commented
Nov 22, 2023
|
|
||
| HtmlUtil._suite_action(wiki_page, string_io, html_data, action="SetUp") | ||
|
|
||
| string_io.writelines([html_data.page_data.get_content()]) |
There was a problem hiding this comment.
Unsure if this writelines needs to be executed here
TianlunHu
reviewed
Nov 22, 2023
| class HtmlProcessData: | ||
| page_data: PageData | ||
| page_crawler: PageCrawlerImpl | ||
| path_parser: PathParser | ||
|
|
There was a problem hiding this comment.
An additional class of HTML parameters may not be necessary
TianlunHu
reviewed
Nov 22, 2023
|
|
||
|
|
||
| class HtmlUtil: | ||
| @staticmethod | ||
| def _suite_action( |
There was a problem hiding this comment.
This name may not be proper to understand what the function is doing
There was a problem hiding this comment.
Overall, I would say that this refactor does not necessarily improve the readability, it only gets rid of the code duplication
SchubertS96
reviewed
Nov 22, 2023
| ) | ||
|
|
||
| if suite_action is not None: | ||
| page_path: WikiPagePath = wiki_page.get_page_crawler().get_full_path( |
There was a problem hiding this comment.
Maybe factor out these few lines into their own function to improve readability, for example "write_page" or similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactoring from Group5