Group 3 #21
Group 3 #21
Conversation
| import Planes.MilitaryPlane; | ||
| import Planes.Plane; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
* import are considered bad in python (no idea about java), clutter the global namespace
|
|
||
| import java.util.*; | ||
|
|
||
| public class Airport { |
| public class Airport { | ||
|
|
||
| /** | ||
| * Prints transport military planes |
There was a problem hiding this comment.
Please add content for documentation
|
|
||
| } // else | ||
| } //for | ||
| System.out.println("model:" + maxPlane.getModel()); |
| */ | ||
| private void printMaxTransportMilitaryPlane() { | ||
| List<MilitaryPlane> transportMilitaryPlanes = new ArrayList<>(); | ||
| Plane maxPlane = null; |
There was a problem hiding this comment.
Move this line to before the for loop.
| * Prints transport military planes | ||
| */ | ||
| private void printMaxTransportMilitaryPlane() { | ||
| List<MilitaryPlane> transportMilitaryPlanes = new ArrayList<>(); |
There was a problem hiding this comment.
| List<MilitaryPlane> transportMilitaryPlanes = new ArrayList<>(); |
Not used
| List<MilitaryPlane> transportMilitaryPlanes = new ArrayList<>(); | ||
| Plane maxPlane = null; | ||
|
|
||
| // print banner |
| System.out.println ("*********************************************"); | ||
| System.out.println ("***** Largest Transport Military Plane ******"); | ||
| System.out.println ("*********************************************"); |
There was a problem hiding this comment.
No white space before opening parenthesis.
| for (Plane plane : planes) { | ||
| if (plane instanceof MilitaryPlane) { | ||
| if (((MilitaryPlane) plane).getType() == MilitaryType.TRANSPORT) { | ||
| if (maxPlane != null && maxPlane.getMaxLoadCapacity() < plane.getMaxLoadCapacity()) { |
There was a problem hiding this comment.
maxPlane is always null. Therefore this is always false, which leads to a seg fault in Line 33.
| else { | ||
|
|
||
| } // else |
| maxPlane = plane; | ||
| } | ||
| } | ||
| } //if |
| else { | ||
|
|
||
| } // else | ||
| } //for |
| System.out.println("capacity:" + maxPlane.getMaxLoadCapacity()); | ||
| } | ||
|
|
||
| //Constructor |
There was a problem hiding this comment.
Please remove empty docu, and please add explicit documentation on the constructor
| //Constructor | ||
| public Airport(List<? extends Plane> planes) { | ||
| this.planes = planes; | ||
| this.printMaxTransportMilitaryPlane(); |
There was a problem hiding this comment.
Please do not call a print fct in a constructor
|
|
||
| private List<? extends Plane> planes; | ||
|
|
||
| public List<? extends Plane> getPlanes() { |
No description provided.