Group 2 #20
Open
Group 2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvjosue
reviewed
Sep 6, 2021
| public class Airport { | ||
|
|
||
| /** | ||
| * Prints transport military planes |
dmitrii-n
reviewed
Sep 6, 2021
| //Constructor | ||
| public Airport(List<? extends Plane> planes) { | ||
| this.planes = planes; | ||
| this.printMaxTransportMilitaryPlane(); |
There was a problem hiding this comment.
why are we printing something in a constructor?
dmitrii-n
reviewed
Sep 6, 2021
| } | ||
| } //if | ||
| else { | ||
|
|
pvjosue
reviewed
Sep 6, 2021
|
|
||
| } // else | ||
| } //for | ||
| System.out.println("model:" + maxPlane.getModel()); |
There was a problem hiding this comment.
This would crash if there are no TRANSPORT planes in the airport, as maxPlane=null, this should be properly handled.
dmitrii-n
reviewed
Sep 6, 2021
|
|
||
| for (Plane plane : planes) { | ||
| if (plane instanceof MilitaryPlane) { | ||
| if (((MilitaryPlane) plane).getType() == MilitaryType.TRANSPORT) { |
There was a problem hiding this comment.
Are we sure this shouldn't be a subclass?
pvjosue
reviewed
Sep 6, 2021
| maxPlane = plane; | ||
| } | ||
| } | ||
| } //if |
There was a problem hiding this comment.
Remove not needed comments and else block.
dmitrii-n
reviewed
Sep 6, 2021
| System.out.println ("***** Largest Transport Military Plane ******"); | ||
| System.out.println ("*********************************************"); | ||
|
|
||
| for (Plane plane : planes) { |
There was a problem hiding this comment.
Shouldn't we always prefix with this?
dmitrii-n
reviewed
Sep 6, 2021
| @@ -0,0 +1,49 @@ | |||
| import models.MilitaryType; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.