-
Notifications
You must be signed in to change notification settings - Fork 126
Updating the way Forseti Server Configuration is retrieved from GCS #480
Updating the way Forseti Server Configuration is retrieved from GCS #480
Conversation
Moved away from `google_storage_object_signed_url` as it requires a local json keyfile and I am deploying using service account impersonation. hashicorp/terraform-provider-google#3558
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I assume this change is partly dependent on the Helm PR?
@hiloboy0119 The lint tests failed for 2 reasons:
|
@hiloboy0119 Following up on this PR, please look into my comments above. |
@hiloboy0119 Another ping on this PR, do you still wish to move forward with this change? |
@hiloboy0119 Checking in to see if you still want to move forward with this PR. |
Thanks @hiloboy0119 for this PR. We are now hitting the same issue on this PR where I am adding tests for the GKE example. I'm going to merge this change into my branch, so that we can fix the tests and include them in the upcoming release. |
Moved away from
google_storage_object_signed_url
as it requiresa local json keyfile and I am deploying using service account
impersonation.
hashicorp/terraform-provider-google#3558