This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Feature/add gke tests #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkowalski-google
requested review from
hshin-g,
kevensen and
morgante
as code owners
gkowalski-google
commented
Mar 9, 2020
| @@ -911,7 +911,7 @@ variable "git_sync_wait" { | |||
|
|
|||
| variable "helm_chart_version" { | |||
| description = "The version of the Helm chart to use" | |||
| default = "2.1.0" | |||
| default = "2.2.0-rc1" | |||
There was a problem hiding this comment.
Currently using this version until 2.2.0 is released.
gkowalski-google
commented
Mar 9, 2020
|
|
||
| it "has the expected status" do | ||
| expect(pod.status.phase).to eq 'Running' | ||
| end |
There was a problem hiding this comment.
These tests will ensure the minimum Forseti pods are running.
|
/gcbrun |
…480) * Updating the way Forseti Server Configuration is retrieved from GCS Moved away from `google_storage_object_signed_url` as it requires a local json keyfile and I am deploying using service account impersonation. hashicorp/terraform-provider-google#3558 * Pinning version of helm provider to ~> v0.10 * Passing helm chart version through the on_gke_end_to_end example to the on_gke module Co-authored-by: Gregg Kowalski <[email protected]>
…s.tf file for on-gke-end-to-end, update helm chart to the 2.2 RC.
…e workload identity race condition.
kevensen
reviewed
Mar 16, 2020
| @@ -69,7 +69,7 @@ locals { | |||
| "storage-api.googleapis.com", | |||
| "groupssettings.googleapis.com", | |||
| ] | |||
| workload_identity = "${var.project_id}.svc.id.goog" | |||
| workload_identity_namespace = var.workload_identity_namespace == null ? "${var.project_id}.svc.id.goog" : var.workload_identity_namespace | |||
There was a problem hiding this comment.
I recommend not making this conditional: input variable or bust.
|
Due to this bug with Helm, these tests will not pass and will need to upgrade to Helm 3 to get the fix. Related to #548 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #515