Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #19

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Update dependencies #19

merged 3 commits into from
Jan 2, 2024

Conversation

jay-lark
Copy link
Contributor

This should resolve every vulnerability shown in Snyk except one.

Reviewer Instructions

  • Ensure that the plan filename matches from the output of the plan and the deployment instructions below.
  • That only the expected changes will occur. No unintentional resources will be changed.

Deployment Instructions

TFC

@jay-lark jay-lark requested a review from a team as a code owner November 22, 2023 15:04
bateller
bateller previously approved these changes Nov 22, 2023
@jay-lark
Copy link
Contributor Author

Close and reopen since snyk tests are failing

@jay-lark jay-lark closed this Nov 22, 2023
@jay-lark jay-lark reopened this Nov 22, 2023
@jay-lark
Copy link
Contributor Author

Looks like Snyk is having an issue right now. I'll try to get the tests running later.

@jay-lark jay-lark closed this Nov 22, 2023
@jay-lark jay-lark reopened this Nov 22, 2023
@jay-lark
Copy link
Contributor Author

Tests were failing because the hashicorp dependencies required a newer version of Go. I've update the GitHub actions accordingly.

@jay-lark
Copy link
Contributor Author

Currently this repository has 4 High vulnerabilities and 2 Medium in Snyk. This takes it to 1 High and 3 mediums. I've asked Adam if we can ignore the snyk test and merge in.

@czeeb
Copy link

czeeb commented Nov 22, 2023

I forced the security/snyk check as passing for the following reasons:

  • We are using the latest dependency versions
  • The vulnerabilities introduced are due to deep external dependencies which are version pinned by their dependency. We are unable to pin versions of these dependencies to resolved versions because of that version pinning.
  • The risk of any vulnerability being leveraged is extremely low. To leverage any of these vulnerabilities Terraform credentials would need to become compromised and a method of leverage the vulnerabilities through Terraform's HCL itself would need to be devised.

The conversation around this happened in a private channel, but for future reference the full conversation can be found here: https://formstack.slack.com/archives/G7409KK7U/p1700681237047739

@jay-lark jay-lark requested a review from bateller January 2, 2024 19:23
@jay-lark jay-lark merged commit 5d51252 into main Jan 2, 2024
5 checks passed
@jay-lark jay-lark deleted the deps branch January 2, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants