Make libjade use DOIT instructions on secrets (p2) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egrep is deprecated.
This spills some more registers to the stack in the reference chacha core. This comes at a significant performance cost. Further experimentation should be done with register packing instead.
But at what cost?!?
The rotate instruction just ignores these, but the ">>=" operators complain.
Fix xsalsa20poly1305 by swapping its xsalsa20 with the DOIT one. Adds declassifies into xsalsa20poly1305. This declassifies the result of tag verification, which leaks via a branch (decryption is not done if tag does not verify).
Make libjade use DOIT instructions on secrets
tfaoliveira
force-pushed
the
main
branch
2 times, most recently
from
51d7c2f
to
68a9144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of: #108