Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alt-ergo 2.5 #33

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Use alt-ergo 2.5 #33

merged 2 commits into from
Mar 20, 2024

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 14, 2024

No description provided.

@vbgl
Copy link
Contributor Author

vbgl commented Mar 14, 2024

Note that I don’t know how to update the docker image that is used in CI. Why isn’t it part of this repo?

@strub
Copy link
Contributor

strub commented Mar 14, 2024

I think it is using the EasyCrypt Docker image. The Docker file is in the EasyCrypt repository.

@vbgl
Copy link
Contributor Author

vbgl commented Mar 15, 2024

So is there any hope for this CI to work?

@vbgl
Copy link
Contributor Author

vbgl commented Mar 15, 2024

Alright. I’ve thus amended the CI job script to install the required version of alt-ergo on every run. It seems to work:
https://github.com/vbgl/hakyber/actions/runs/8295929534

@strub
Copy link
Contributor

strub commented Mar 16, 2024

In fact, I don't understand from where the Docker image comes. The EC one contains Alt-Ergo 2.4 & 2.5...

@strub
Copy link
Contributor

strub commented Mar 16, 2024

Let's wait for that.

#34

@strub strub mentioned this pull request Mar 19, 2024
@strub strub self-requested a review March 19, 2024 10:27
@vbgl vbgl merged commit 335417e into formosa-crypto:master Mar 20, 2024
3 checks passed
@vbgl vbgl deleted the alt-ergo-2.5 branch March 20, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants