-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace keccakf1600 - with significant performance improvements for ref #24
Conversation
If you split this PR in two halves, I think I can manage to do the proof for the REF implementation (while postponing the proof for the AVX2 version). |
Well, no longer sure about my previous statement… |
acee459
to
e4a0d24
Compare
I’m done fixing the proofs. I’ve removed a few redundant instructions. |
… one in ref and avx2 (some extra spills were needed) Co-authored-by: Vincent Laporte <[email protected]>
e4a0d24
to
82d5ba7
Compare
Hi Vincent, thank you for pushing on this. Do you think it is ready to be merged? |
Yes it is, if you don’t complain about the changes I’ve made to the code. |
I don't complain. At some point, maybe during the next retreat, I would like to discuss compiler warnings with you and the compiler team. |
Thanks. There was no need to squash the three changes into a single commit. |
comparison basis (left side): https://github.com/formosa-crypto/libjade/tree/bb8569c01597338148800210de5aa2b512f783c6
new cycles for ref: formosa-crypto/libjade@b53d837
new cycles avx2: formosa-crypto/libjade@7046ee9
ref
avx2