Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace keccakf1600 - with significant performance improvements for ref #24

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

tfaoliveira
Copy link
Member

comparison basis (left side): https://github.com/formosa-crypto/libjade/tree/bb8569c01597338148800210de5aa2b512f783c6

new cycles for ref: formosa-crypto/libjade@b53d837
new cycles avx2: formosa-crypto/libjade@7046ee9

ref

keypair, 302134 -> 220474
enc    , 351866 -> 267840
dec    , 424384 -> 339360

avx2

keypair, 85284 -> 83438
enc    , 82856 -> 80916
dec    , 83982 -> 82122

@tfaoliveira tfaoliveira requested a review from vbgl February 9, 2024 22:09
@vbgl
Copy link
Contributor

vbgl commented Feb 12, 2024

If you split this PR in two halves, I think I can manage to do the proof for the REF implementation (while postponing the proof for the AVX2 version).

@vbgl
Copy link
Contributor

vbgl commented Feb 13, 2024

Well, no longer sure about my previous statement…

@vbgl
Copy link
Contributor

vbgl commented Feb 16, 2024

I’m done fixing the proofs. I’ve removed a few redundant instructions.

@vbgl vbgl marked this pull request as ready for review February 16, 2024 21:46
@tfaoliveira
Copy link
Member Author

Hi Vincent, thank you for pushing on this. Do you think it is ready to be merged?

@vbgl
Copy link
Contributor

vbgl commented Feb 20, 2024

Yes it is, if you don’t complain about the changes I’ve made to the code.

tfaoliveira added a commit to formosa-crypto/libjade that referenced this pull request Feb 21, 2024
@tfaoliveira
Copy link
Member Author

I don't complain. At some point, maybe during the next retreat, I would like to discuss compiler warnings with you and the compiler team.

@tfaoliveira tfaoliveira merged commit 2a441f8 into master Feb 21, 2024
6 checks passed
@tfaoliveira tfaoliveira deleted the replace_keccakf branch February 21, 2024 22:14
@vbgl
Copy link
Contributor

vbgl commented Feb 22, 2024

Thanks. There was no need to squash the three changes into a single commit.

Rixxc pushed a commit to formosa-crypto/libjade that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants