Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9321 fixed onlyAlailableItems validation for select Boxes #194

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented Nov 20, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9321

Description

The problem of incorrect Only Available Items validation of the Select Boxes component value has been fixed.
The value of the Select boxes component is a map with pairs key (value option) - value (true or false). Therefore the check for the difference between the data value keys and allowed options values has been added.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Automated tests have been added. All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but shouldn't we add the same condition to the synchronous version of this function (for, I guess, static values only)?

@brendanbond brendanbond merged commit c7ac015 into master Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants