Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9329: fix issue where validateWhenHidden now validates hidden and conditionally hidden components #191

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9329

Description

What changed?

Changes to when we validate based on visibility, namely that the shouldSkipValidation function checks for the validateWhenHidden flag AND general visibility (so both conditionally hidden components and intentionally hidden ones).

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Tests here are passing, automated tests were included in @formio/js

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 770d1df into master Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants