FIO-9266,FIO-9267,FIO-9268: Fixes an issue where nested forms will be not validated if there are no data provided #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated if there are no data provided
|
Please write a test. I am relying on those tests as I am in the process of refactoring the "path" issues. |
travist
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9266
https://formio.atlassian.net/browse/FIO-9267
https://formio.atlassian.net/browse/FIO-9268
Description
Previously, we were skipping processing any Nested Form's child components if there were no data provided for it (if the empty object was provided, it woould not skip though). That was causing an issue with submissions made through API that do not indlude data for the neste form, but must be still validated (because some fields of the child form are required, for example).
After discussion on the dev support we decide that the aussumptions that we can skip processing of nested form's child components if it has no data was wrong and we have to change it.
There are still some cases when we want to skip it: when the nested form's submission is saved as reference and its data is not attached (that means that the child form's data was already validated and saved to DB) or when the nested form itself should be hidden and cleared on hide.
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: