Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8778: add case for map component model type in filter; add tests #129

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Aug 5, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8778

Description

The filter process was not accounting for "map" model types, which resemble "object" model types but crucially don't have child components (or at least, child components that get iterated into). This PR updates the getModelType function to account for the "map" model type.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Added some automated tests.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 8ecadf8 into master Aug 8, 2024
6 checks passed
lane-formio pushed a commit that referenced this pull request Aug 12, 2024
FIO-8778: add case for map component model type in filter; add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant