All logic and styles are contained in the index.html file

[ChristofLee]

I would suggest moving the custom CSS and JS to their own files.

Then using the Gulp task created in #7 to minify/uglify these files ready for production.

[PrabhanshuAttri]

@ChristofLee I was thinking of creating this issue. Could you please separate styles and js code to separate files. After this, we can merge gulp minification as well.

[Captain-DarkO]

shall I?

[PrabhanshuAttri]

@DeeJay-NuKe This issue is already assigned to @ChristofLee. Explore the webpage and let us know if something needs to be added to the page.

[Captain-DarkO]

okay 👍

[ChristofLee]

I can do the work based on #6 .

However I think it would be best to review, test and merge my PR #6 and then review this issue as a separate PR.

I think it would make it easier for you to review my changes individually, instead of one huge PR.

It's up to you, just a suggestion.

[ChristofLee]

I have submitted a PR for this #10 but it may contain conflicts because it waits on #6 .

Please let me know if you need anything more from me 👍

There are some enhancements that could be implemented to the CSS and JS but they could/should be raised as issues to let more people get a chance to create features.

[PrabhanshuAttri]

Thanks @ChristofLee. Good going. As #6 is assigned to someone else, could you please just separate the CSS and JS. @fatimarafiqui can work on gulp task.

Feel free to open issues. :)

[fatimarafiqui]

@PrabhanshuAttri @ChristofLee I am working on the minification issue.

[ChristofLee]

This is highly dependent on the file structure and the way the minification is implemented.

I would need to wait and see how @fatimarafiqui implements it before I could make a viable Pull Request.

Another issue, @tommyka has created a PR on top of #6 to add browsersync. At this point it would be faster and easier to use my PR #7 and allow @fatimarafiqui to make changes as they see fit.

Also, if you are only allowing the assigned person to work on the issue, please assign the ticket to them.

[PrabhanshuAttri]

@ChristofLee and @tommyka good to see you guys collaborate. I didn't expect this amount of response for this repository that's why I was not assigning the issues. It was expected that the contributor would read the issues and comments before creating the PR.

Don't worry your PR won't get rejected. That said, @fatimarafiqui PR looks good. I will merge her PR and then @ChristofLee you can just rebase your 2 pending PRs with all missing features/fixes. I believe this would be fair to all.

It is advised to discuss before adding features.
Thanks @ChristofLee @fatimarafiqui and @tommyka

[PrabhanshuAttri]

@ChristofLee @fatimarafiqui and @tommyka Feel free to contribute to PyBeacon as well. Eddyst.one is just a side project for PyBeacon.

[ChristofLee]

@PrabhanshuAttri That sounds good to me (and fair) 👍 I've been doing Hacktoberfest, and I had free time yesterday so was just trying to get my PR's in ;) (couldn't wait until today).

I have made another suggestion #16 which might make things easier.

Will check out PyBeacon too. If there is anything specific you want me to take a look at, tag me in 👍

Something I have done in the past with open source projects is create a Gitter channel. This would help communication and the discussion of ideas. Might be a route to consider?

@PrabhanshuAttri @fatimarafiqui If your PR can be finished within the next 2 days, I will do like you suggested and rebase my changes. Unfortunately, after that I won't be available 👎

[PrabhanshuAttri]

@ChristofLee I understand. As far as I know, PR doesn't have to be merged. We do have a slack channel for communication. You can invite yourself using this link. Please make changes to your PR so that I can review and merge them.

[ChristofLee]

@PrabhanshuAttri I think there may be an error on that link.

Failed! Something has gone wrong. Please contact a system administrator.

[PrabhanshuAttri]

Try again

[ChristofLee]

Nope, still receiving that same error message 👎

[PrabhanshuAttri]

Could you please specify which link? I must have misunderstood.

[ChristofLee]

Sorry, after clicking the link, I enter my email, and get the error message. Please see screenshot.

http://nirmankarta.herokuapp.com/

[PrabhanshuAttri]

Try now.