This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Separate logic and styles contained in index.html #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define object of configurable settings - Move JS files into build directory for organisation - Git ignore the npm modules - Update link to JS scripts
- Move our build and generate our dist files - Install NPM package
- Add a main partial for our custom styles - Move semantic css into a vendor folder - Create main style file - Link to main style file
- Move form.js into vendor dir - Remove script from index page
ChristofLee
commented
Oct 30, 2017
| @@ -0,0 +1,81 @@ | |||
| var urlRegex = /^(http:\/\/www\.|https:\/\/www\.|http:\/\/|https:\/\/)[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(\/.*)?$/g; | |||
There was a problem hiding this comment.
Hoisted variables out of doc ready.
ChristofLee
commented
Oct 30, 2017
| var urlRegex = /^(http:\/\/www\.|https:\/\/www\.|http:\/\/|https:\/\/)[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?(\/.*)?$/g; | ||
| var initialUrl = 'https://eddyst.one/'; | ||
|
|
||
| function make2Digit(d) { |
There was a problem hiding this comment.
Hoisted functions out of doc ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes from #6 , suggest accepting that PR first, before reviewing this.
This PR should solve issue #8. It separates the CSS and JS scripts into their own files and folders.
It should be easier to manage going forward, using a standardised file tree.