Bryan/completion routine fix #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore taillight pool tag to WDF allocations. Simplified code by querying strings from only IO targets. Change comments to not use American expressions. Got to matching based on the PDO name. Tie PnP callback removal to the lifetime of the device object. Revert KdPrintEx to KdPrint. Add documentation and document multithreaded code. Swith to RAII in SetBlackAsync for the target. Improvements for better readability and reliability versus performance. Use C copy trick and update a comment.
…m struct size of 8 bytes (3) Log SetBlackAsync failures
ManOnTheMountainTech
force-pushed
the
bryan/completion_routine_fix
branch
from
6c3e235 to
e4b1258
Compare
forderud
requested changes
Mar 23, 2024
I would then recommend you to first focus on getting #54 approved & merged. You can work on enhancements on top of that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WdfRequestSend()just checks to see if the request was delivered to the target driver. This fix sets the block further requests flag after checking the final result of the request in the completion routine.