This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Removing UIKit to prepare the way to support OS X with this library #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OSx target not created yet but code should be good to go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #35.
It is the first step to making project compatible with OSx. It removes UIKit from where it is not needed.
The class
DSAPINetworkIndicatorControlleris left as is for iOS but the methods are essentially stubs for OSx. There are a few ways to handle this but I took the path of least amount of change before a new target is created.This PR does not include a new OSx target as I wanted to keep the changes very focused on just removing UIKit wherever possible.