Skip to content

Fast fail when runtime errors occur

Compare
Choose a tag to compare
@adamhenson adamhenson released this 15 Jul 00:18
· 15 commits to master since this release

Summary

In light of #99 this GitHub Action will now fail a job when Lighthouse results in a runtime error (only applies to "local" Lighthouse runs). This GitHub Action allows for multiple Lighthouse audits within a single job, so if any encounter a runtime error - it will "fast fail" the entire job. maxRetries input will cover these errors and retry if set.

There is an argument to not fast fail the job when these types of errors occur as one may want to preserve runs of other Lighthouse audits within the job, however this would lead to complications in downstream behavior and could cause silent, ignored issues that may eventually become tricky to pinpoint. If a Lighthouse audit is failing with runtime errors, something is wrong that should be addressed, hence another justification of failing the job.

Because this release changes the way errors are handled it is considered a major change in terms of versioning.