Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): Only use icons which are wanted for inclusion if given … #14

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

feat(parser): Only use icons which are wanted for inclusion if given … #14

wants to merge 3 commits into from

Conversation

lubber-de
Copy link
Member

Description

This PR adds a proposal solution to support CSS generation for only wanted icons to be able to reduce the overall CSS.
If somebody wants to only generate CSS for some known icons instead of the whole Font Awesome set, the file include_icons.json, should be adjusted to hold an array of font-awesome names.

[
  "address-book",
  "address-card",
  "adobe"
]

@lubber-de lubber-de added the enhancement New feature or request label May 31, 2019
@y0hami
Copy link
Member

y0hami commented May 31, 2019

I like the idea and the code is good but I don't think this should be in src and we should move it into the CLI itself like asking the user if they want to only include some icons and if they do they specify a file path to a JSON file like the proposal which the CLI will then use.

@y0hami
Copy link
Member

y0hami commented May 31, 2019

We should also add a not include alternative.

@lubber-de
Copy link
Member Author

lubber-de commented May 31, 2019 •
edited
Loading

Agreed, as said, it was just a proposal. You may adjust the code accordingly when you've time and use this PR only as reference and close it. 😉

@lubber-de
Merge branch 'develop' into feat/included_icons
c0fd068 
# Conflicts:
#	src/parsers/FontAwesome.ts
@lubber-de lubber-de changed the base branch from master to develop August 20, 2021 06:36
@lubber-de lubber-de marked this pull request as draft December 31, 2022 17:57
@lubber-de lubber-de removed the request for review from exoego December 31, 2022 17:58
@hennihaus
Copy link

When can we expect this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @y0hami @hennihaus