-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slider): customizable event selectors #2330
base: develop
Are you sure you want to change the base?
Conversation
I like the idea! Unfortunately, this doesn't work as expected. Here is an extended JSFiddle with the code from this PR showing the different options: The mouse setting does not have an effect due to the additional Setting |
Thanks for taking a look!
oh, yes, the second one seems to override the first (which is taking care of event bubbling...)
Makes sense 👍🏼 I'll test this. Thanks for the hint! |
# Conflicts: # src/definitions/modules/slider.js
# Conflicts: # src/definitions/modules/slider.js
Description
This PR makes the event selector target customizable via settings, so the initial idea of #1987 would be now easier doable based on the new codebase from #2327
@mhthies Please review, i am interested in your opinion
Testcase
https://jsfiddle.net/lubber/k3efcLuj/1/
https://fomantic-ui.com/jsfiddle/#!lubber/k3efcLuj/1/ (for mobile device testing)
Replaces
#1987