Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPBEX-62 Unable to save transfer configuration #130

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

chris-hellen
Copy link
Contributor

Purpose

To make sure a valid value is input into the interval component.

Approach

In order for users to make sure they input a correct interval value, error checking and a warning message was added when an invalid value is input.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@chris-hellen chris-hellen requested a review from ncovercash July 2, 2024 16:27
Copy link

github-actions bot commented Jul 2, 2024

Jest Unit Test Results

  1 files  ±0   73 suites  ±0   4m 7s ⏱️ -11s
401 tests ±0  401 ✅ +1  0 💤 ±0  0 ❌  - 1 
439 runs  ±0  439 ✅ +1  0 💤 ±0  0 ❌  - 1 

Results for commit ac04ce5. ± Comparison against base commit 7390880.

♻️ This comment has been updated with latest results.

@chris-hellen chris-hellen requested a review from ncovercash July 2, 2024 21:11
Copy link

sonarqubecloud bot commented Jul 3, 2024

@chris-hellen chris-hellen merged commit 92b9f8f into master Jul 3, 2024
15 checks passed
@chris-hellen chris-hellen deleted the UIPBEX-62 branch July 3, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants