UIPBEX-50 #127
Open
UIPBEX-50 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red tests/translations to accommodate.
…nslations to accomodate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added dynamic accessibility label's to all select elements so that screen readers can get an accurate picture of intended use. This is necessary so that blind/visually impaired users are able to understand and interact with the page.
[JIRA Issue](https://folio-org.atlassian.net/browse/UIPBEX-50 atlOrigin=eyJpIjoiM2E4MjkzMzg5ZmY1NDNiNmFlZWQ2YjEzN2FjZTkyZjYiLCJwIjoiaiJ9)
Approach
Fetched the selected choice from the select element and passed that value to the 'aria-label' prop. Added label elements so that there were no visible changes. Adapted translations so that internationalization would still function.