Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPBEX-58-fix: Check token.conditions is defined and is an array #121

Merged
merged 1 commit into from
May 8, 2024

Conversation

danetsao
Copy link
Contributor

@danetsao danetsao commented May 8, 2024

Continued on UIPBEX-58.

How does this look as a preventative fix? Looks like the issue is coming from this, a conditional text without 'condition' was saved. So we want to prevent this from being saved without a condition right?

Screenshot 2024-05-08 at 3 37 45 PM

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@danetsao danetsao requested a review from ncovercash May 8, 2024 20:42
Copy link

github-actions bot commented May 8, 2024

Jest Unit Test Results

  1 files  ±0   73 suites  ±0   4m 14s ⏱️ -12s
401 tests ±0  401 ✅ ±0  0 💤 ±0  0 ❌ ±0 
439 runs  ±0  439 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 63d75cb. ± Comparison against base commit b04e2c7.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented May 8, 2024

@danetsao danetsao changed the title Check token.conditions is defined and is an array UIPBEX-58-fix: Check token.conditions is defined and is an array May 8, 2024
@danetsao danetsao merged commit 86d717e into master May 8, 2024
16 checks passed
@danetsao danetsao deleted the UIPBEX-58-fix branch May 8, 2024 21:22
zburke pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants