-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIPBEX-58: Add error checking for invalid config. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncovercash
reviewed
Apr 25, 2024
ncovercash
approved these changes
Apr 25, 2024
Co-authored-by: Noah Overcash <[email protected]>
bvsharp
approved these changes
Apr 25, 2024
Jest Unit Test Results 1 files ±0 73 suites ±0 4m 18s ⏱️ -2s Results for commit 1be261a. ± Comparison against base commit 31c80a3. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
|
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per UIPBEX-58, a try/catch has been added to the
useInitialValues
hook, as well as better error handling surrounding the problem areas from the failure.I am not sure to what level of error checking we should have, so let me know if my progress so far is good and what other areas you think may need better error handling.