Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPBEX-58: Add error checking for invalid config. #118

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

danetsao
Copy link
Contributor

Per UIPBEX-58, a try/catch has been added to the useInitialValues hook, as well as better error handling surrounding the problem areas from the failure.

I am not sure to what level of error checking we should have, so let me know if my progress so far is good and what other areas you think may need better error handling.

@danetsao danetsao requested a review from ncovercash April 25, 2024 16:10
Copy link

github-actions bot commented Apr 25, 2024

Jest Unit Test Statistics

    1 files  ±0    73 suites  ±0   1m 50s ⏱️ -1s
401 tests +2  401 ✔️ +2  0 💤 ±0  0 ±0 
439 runs  +2  439 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit bec2381. ± Comparison against base commit f2a8ec9.

♻️ This comment has been updated with latest results.

Copy link

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 32d8c8d. ± Comparison against base commit f2a8ec9.

Co-authored-by: Noah Overcash <[email protected]>
Copy link

Jest Unit Test Results

  1 files  ±0   73 suites  ±0   4m 18s ⏱️ -2s
401 tests +2  401 ✅ +2  0 💤 ±0  0 ❌ ±0 
439 runs  +2  439 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 1be261a. ± Comparison against base commit 31c80a3.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
 initial values hook ‑  initial values hook
dtoToAggregateCriteria with undefined amount dtoToAggregateCriteria({   type: 'Aggregate',   property: 'TOTAL_AMOUNT',   condition: 'GREATER_THAN',   amount: '' }) === undefined ‑ dtoToAggregateCriteria with undefined amount dtoToAggregateCriteria({   type: 'Aggregate',   property: 'TOTAL_AMOUNT',   condition: 'GREATER_THAN',   amount: '' }) === undefined
useInitialValues initial values hook with invalid data ‑ useInitialValues initial values hook with invalid data
useInitialValues initial values hook ‑ useInitialValues initial values hook

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ncovercash ncovercash merged commit fb9769f into master Apr 25, 2024
14 of 15 checks passed
@ncovercash ncovercash deleted the UIPBEX-58 branch April 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants