Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPBEX-57 bump up react version #104

Merged
merged 1 commit into from
Oct 16, 2023
Merged

UIPBEX-57 bump up react version #104

merged 1 commit into from
Oct 16, 2023

Conversation

NikitaSedyx
Copy link
Contributor

@NikitaSedyx NikitaSedyx commented Oct 16, 2023

Purpose

[URGENT] required for Poppy release

react 18 upgrade

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Jest Unit Test Statistics

46 tests  ±0   46 ✔️ ±0   37s ⏱️ -7s
12 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 765043d. ± Comparison against base commit 31d9212.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 765043d. ± Comparison against base commit 31d9212.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@NikitaSedyx NikitaSedyx assigned NikitaSedyx and vashjs and unassigned NikitaSedyx Oct 16, 2023
@vashjs vashjs requested a review from a team October 16, 2023 14:46
@vashjs vashjs merged commit d346977 into master Oct 16, 2023
5 checks passed
@vashjs vashjs deleted the UIPBEX-57 branch October 16, 2023 15:20
@zburke
Copy link
Member

zburke commented Oct 16, 2023

@NikitaSedyx, whoops, I missed a typo: "react-dom": "^118.2.0",. Our react version is off by an order of magnitude 😆 . It's only a peer-dep so it'll generate a warning without actually causing a build problem but this would be nice to fix since we haven't released yet. What do you think?

@zburke zburke mentioned this pull request Oct 16, 2023
11 tasks
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react": "^18.2.0",
"react-dom": "^118.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

118

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all three of us missed it here 😬 . @vashjs fixed it for us in #105 when he published the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants