-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIPBEX-55: Also support feesfines interface version 19.0 #103
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new okapiInterface
value looks fine, but the version in the CHANGELOG and in package.json
do not align so you need to update one or the other. Note that adding support for an interface version is not a breaking change, so this change alone does not force a major version update.
@Dmitriy-Litvinenko , sorry I did not read your PR description ("this is part of Quesnelia (R1 2024) release") in detail. If you want to work on Q features now, that's fine, but you need to bump the version in
|
@zburke Could you please review (package.json updated)? Current pull request will be merged after release previous release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please make sure when v3.0.0 gets released that you split a b3.0
branch from the previous commit :)
ab7607e
to
1ff101c
Compare
1ff101c
to
51bf49d
Compare
Kudos, SonarCloud Quality Gate passed! |
Purpose
Also support
feesfines
interface version19.0
Approach
Changes was in endpoint
/accounts
that do not used in current moduleThis is part of
Quesnelia (R1 2024)
releaseShould be merged after merging https://issues.folio.org/browse/MODFEE-337
Refs
https://issues.folio.org/browse/UIPBEX-55