Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPBEX-55: Also support feesfines interface version 19.0 #103

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Oct 11, 2023

Purpose

Also support feesfines interface version 19.0

Approach

Changes was in endpoint /accounts that do not used in current module
This is part of Quesnelia (R1 2024) release
Should be merged after merging https://issues.folio.org/browse/MODFEE-337

Refs

https://issues.folio.org/browse/UIPBEX-55

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Jest Unit Test Statistics

46 tests  ±0   46 ✔️ ±0   33s ⏱️ -16s
12 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 51bf49d. ± Comparison against base commit 64e622a.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 51bf49d. ± Comparison against base commit 64e622a.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new okapiInterface value looks fine, but the version in the CHANGELOG and in package.json do not align so you need to update one or the other. Note that adding support for an interface version is not a breaking change, so this change alone does not force a major version update.

@zburke
Copy link
Member

zburke commented Oct 11, 2023

@Dmitriy-Litvinenko , sorry I did not read your PR description ("this is part of Quesnelia (R1 2024) release") in detail. If you want to work on Q features now, that's fine, but you need to bump the version in package.json first. It's fine to do that now; when you prepare the P-release, just split a branch from the last commit before the version bump and make the release from that branch:

git checkout -b b3.0 <some commit hash>
git push -u origin head
// ... prepare final v3.0.0 CHANGELOG entry etc, and tag the release on a commit on the `b3.0` branch

@Dmitriy-Litvinenko
Copy link
Contributor Author

@zburke Could you please review (package.json updated)? Current pull request will be merged after release previous release.

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested review from zburke and a team October 12, 2023 08:38
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure when v3.0.0 gets released that you split a b3.0 branch from the previous commit :)

@Dmitriy-Litvinenko Dmitriy-Litvinenko force-pushed the UIPBEX-55 branch 3 times, most recently from ab7607e to 1ff101c Compare October 17, 2023 11:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit 66e2726 into master Oct 18, 2023
5 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UIPBEX-55 branch October 18, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants