Refactor nest functions

folio-org · Feb 21, 2024 · da5f505 · da5f505
1 parent 327b743
commit da5f505
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/src/components/Criteria/CriteriaCard.tsx b/src/components/Criteria/CriteriaCard.tsx
@@ -33,21 +33,21 @@ export default function CriteriaCard({
     format: (value) => value ?? CriteriaTerminalType.PASS,
   }).input.value;
 
-  const cardInterior = useMemo(() => {
-    const noneOfReturnType = (
-      <FieldArray name={`${name}.criteria`}>
-        {({ fields }) => fields.map((innerName, index) => (
-          <CriteriaCard
-            key={innerName}
-            name={innerName}
-            alone={fields.length === 1}
-            onRemove={() => fields.remove(index)}
-          />
-        ))
-        }
-      </FieldArray>
-    );
+  const noneOfReturnType = useMemo(() => (
+    <FieldArray name={`${name}.criteria`}>
+      {({ fields }) => fields.map((innerName, index) => (
+        <CriteriaCard
+          key={innerName}
+          name={innerName}
+          alone={fields.length === 1}
+          onRemove={() => fields.remove(index)}
+        />
+      ))
+      }
+    </FieldArray>
+  ), [name]);
 
+  const cardInterior = useMemo(() => {
     switch (type) {
       case CriteriaTerminalType.PASS:
         return <div />;
@@ -103,7 +103,7 @@ export default function CriteriaCard({
       default:
         return <Loading />;
     }
-  }, [name, type]);
+  }, [name, noneOfReturnType, type]);
 
   return (
     <Card