Fix lint errors

folio-org · Feb 21, 2024 · 6e0babb · 6e0babb
1 parent d2b7cd1
commit 6e0babb
Show file tree

Hide file tree

Showing 25 changed files with 150 additions and 216 deletions.
diff --git a/src/api/dto/from/dtoToCriteria.test.ts b/src/api/dto/from/dtoToCriteria.test.ts
@@ -165,9 +165,7 @@ describe('DTO to criteria conversion for initial values', () => {
         feeFineOwnerId: 'owner-id',
       },
     ],
-  ])('converts fee type %s with known types %s to %s', (input, feeFineTypes, expected) =>
-    expect(dtoToCriteria(input, feeFineTypes, [], { currency: 'USD' } as StripesType, intlEn)).toEqual(expected),
-  );
+  ])('converts fee type %s with known types %s to %s', (input, feeFineTypes, expected) => expect(dtoToCriteria(input, feeFineTypes, [], { currency: 'USD' } as StripesType, intlEn)).toEqual(expected));
 
   it.each<[BursarExportFilterLocation, LocationDTO[], CriteriaTerminal]>([
     [
@@ -204,9 +202,9 @@ describe('DTO to criteria conversion for initial values', () => {
         locationId: 'location-id',
       },
     ],
-  ])('converts location %s with known locations %s to %s', (input, locations, expected) =>
-    expect(dtoToCriteria(input, [], locations, { currency: 'USD' } as StripesType, intlEn)).toEqual(expected),
-  );
+  ])('converts location %s with known locations %s to %s', (input, locations, expected) => expect(
+    dtoToCriteria(input, [], locations, { currency: 'USD' } as StripesType, intlEn)
+  ).toEqual(expected));
 
   it('converts amount with EUR currency', () => {
     const input: BursarExportFilterDTO = { type: 'Amount', condition: 'LESS_THAN', amount: 124 };

diff --git a/src/api/dto/from/dtoToLengthControl.test.ts b/src/api/dto/from/dtoToLengthControl.test.ts
@@ -6,6 +6,4 @@ test.each([
     { character: 'a', length: 3, direction: 'FRONT', truncate: false },
     { character: 'a', length: '3', direction: 'FRONT', truncate: false },
   ],
-] as const)('Length control conversion from %s to %s', (input, expected) =>
-  expect(dtoToLengthControl(input)).toEqual(expected),
-);
+] as const)('Length control conversion from %s to %s', (input, expected) => expect(dtoToLengthControl(input)).toEqual(expected));
diff --git a/src/api/dto/from/dtoToScheduling.test.ts b/src/api/dto/from/dtoToScheduling.test.ts
@@ -81,6 +81,4 @@ test.each<[SchedulingDTO, FormValues['scheduling']]>([
       ],
     },
   ],
-])('Converts scheduling DTO %s to %s', (input, expected) =>
-  expect(dtoToScheduling(input, LOCALE_WEEKDAYS)).toEqual(expected),
-);
+])('Converts scheduling DTO %s to %s', (input, expected) => expect(dtoToScheduling(input, LOCALE_WEEKDAYS)).toEqual(expected));
diff --git a/src/api/dto/from/dtoToTransfer.test.ts b/src/api/dto/from/dtoToTransfer.test.ts
@@ -64,7 +64,7 @@ describe('dtoToTransfer', () => {
         },
       },
     ],
-  ])('Converts transfer DTO %s with known accounts %s to %s', (input, transferAccounts, expected) =>
-    expect(dtoToTransfer(input, [], [], transferAccounts, { currency: 'USD' } as StripesType, intlEn)).toEqual(expected),
-  );
+  ])('Converts transfer DTO %s with known accounts %s to %s', (input, transferAccounts, expected) => expect(dtoToTransfer(
+    input, [], [], transferAccounts, { currency: 'USD' } as StripesType, intlEn
+  )).toEqual(expected));
 });
diff --git a/src/api/dto/to/dataToDto.ts b/src/api/dto/to/dataToDto.ts
@@ -110,7 +110,7 @@ export function dataTokenToDto(token: DataToken): BursarExportDataTokenDTO {
 }
 
 export function userDataToDto(token: DataToken & { type: DataTokenType.USER_DATA }): BursarExportDataTokenDTO {
-  if (token.userAttribute == 'FOLIO_ID') {
+  if (token.userAttribute === 'FOLIO_ID') {
     return {
       type: 'UserData',
       value: token.userAttribute,

diff --git a/src/api/dto/to/formValuesToDto.test.ts b/src/api/dto/to/formValuesToDto.test.ts
@@ -61,23 +61,21 @@ describe('Form values conversion', () => {
     },
   };
 
-  it('converts non-aggregate values', () =>
-    expect(formValuesToDto({ ...TEST_VALUE, aggregate: false })).toEqual({
-      ...EXPECTED,
-      groupByPatron: false,
-      data: [{ type: 'Constant', value: 'non-aggregate data' }],
-    }));
+  it('converts non-aggregate values', () => expect(formValuesToDto({ ...TEST_VALUE, aggregate: false })).toEqual({
+    ...EXPECTED,
+    groupByPatron: false,
+    data: [{ type: 'Constant', value: 'non-aggregate data' }],
+  }));
 
-  it('converts aggregate values', () =>
-    expect(formValuesToDto({ ...TEST_VALUE, aggregate: true })).toEqual({
-      ...EXPECTED,
-      groupByPatron: true,
-      groupByPatronFilter: {
-        type: 'Aggregate',
-        amount: 0,
-        condition: 'GREATER_THAN_EQUAL',
-        property: 'NUM_ROWS',
-      },
-      data: [{ type: 'Constant', value: 'aggregate data' }],
-    }));
+  it('converts aggregate values', () => expect(formValuesToDto({ ...TEST_VALUE, aggregate: true })).toEqual({
+    ...EXPECTED,
+    groupByPatron: true,
+    groupByPatronFilter: {
+      type: 'Aggregate',
+      amount: 0,
+      condition: 'GREATER_THAN_EQUAL',
+      property: 'NUM_ROWS',
+    },
+    data: [{ type: 'Constant', value: 'aggregate data' }],
+  }));
 });
diff --git a/src/api/mutators/useAutomaticSchedulerMutation.test.tsx b/src/api/mutators/useAutomaticSchedulerMutation.test.tsx
@@ -26,12 +26,11 @@ describe('Automatic scheduling mutation', () => {
   });
 
   const contextMock = jest.fn();
-  const wrapper = ({ children }: { children: ReactNode }) =>
-    withIntlConfiguration(
-      <QueryClientProvider client={new QueryClient()}>
-        <CalloutContext.Provider value={{ sendCallout: contextMock }}>{children}</CalloutContext.Provider>
-      </QueryClientProvider>,
-    );
+  const wrapper = ({ children }: { children: ReactNode }) => withIntlConfiguration(
+    <QueryClientProvider client={new QueryClient()}>
+      <CalloutContext.Provider value={{ sendCallout: contextMock }}>{children}</CalloutContext.Provider>
+    </QueryClientProvider>,
+  );
 
   it('handles successful responses', async () => {
     const { result: mutator } = renderHook(() => useAutomaticSchedulerMutation(), { wrapper });
@@ -45,22 +44,18 @@ describe('Automatic scheduling mutation', () => {
       } as any);
     });
 
-    await waitFor(() =>
-      expect(postMock).toHaveBeenLastCalledWith('data-export-spring/configs', {
-        json: {
-          type: 'BURSAR_FEES_FINES',
-          exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
-          schedulingData: 'is here!',
-        },
-      }),
-    );
-
-    await waitFor(() =>
-      expect(contextMock).toHaveBeenLastCalledWith({
-        type: 'success',
-        message: 'Configuration saved',
-      }),
-    );
+    await waitFor(() => expect(postMock).toHaveBeenLastCalledWith('data-export-spring/configs', {
+      json: {
+        type: 'BURSAR_FEES_FINES',
+        exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
+        schedulingData: 'is here!',
+      },
+    }));
+
+    await waitFor(() => expect(contextMock).toHaveBeenLastCalledWith({
+      type: 'success',
+      message: 'Configuration saved',
+    }));
   });
 
   it('handles error responses', async () => {
@@ -75,24 +70,20 @@ describe('Automatic scheduling mutation', () => {
       } as any);
     });
 
-    await waitFor(() =>
-      expect(postMock).toHaveBeenLastCalledWith('data-export-spring/configs', {
-        json: {
-          type: 'BURSAR_FEES_FINES',
-          exportTypeSpecificParameters: {
-            bursarFeeFines: 'bursar data that fails',
-          },
-          schedulingData: 'is here!',
+    await waitFor(() => expect(postMock).toHaveBeenLastCalledWith('data-export-spring/configs', {
+      json: {
+        type: 'BURSAR_FEES_FINES',
+        exportTypeSpecificParameters: {
+          bursarFeeFines: 'bursar data that fails',
         },
-      }),
-    );
-
-    await waitFor(() =>
-      expect(contextMock).toHaveBeenLastCalledWith({
-        type: 'error',
-        message: 'Failed to save job',
-      }),
-    );
+        schedulingData: 'is here!',
+      },
+    }));
+
+    await waitFor(() => expect(contextMock).toHaveBeenLastCalledWith({
+      type: 'error',
+      message: 'Failed to save job',
+    }));
   });
 
   it('calls post when no initial config is available', async () => {
@@ -144,15 +135,13 @@ describe('Automatic scheduling mutation', () => {
       } as any);
     });
 
-    waitFor(async () =>
-      expect(putMock).toHaveBeenCalledWith('data-export-spring/configs/foo', {
-        json: {
-          id: 'foo',
-          exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
-          schedulingData: 'is here!',
-        },
-      }),
-    );
+    waitFor(async () => expect(putMock).toHaveBeenCalledWith('data-export-spring/configs/foo', {
+      json: {
+        id: 'foo',
+        exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
+        schedulingData: 'is here!',
+      },
+    }));
     expect(postMock).not.toHaveBeenCalled();
 
     // check invalidation

diff --git a/src/api/mutators/useManualSchedulerMutation.test.tsx b/src/api/mutators/useManualSchedulerMutation.test.tsx
@@ -16,12 +16,11 @@ jest.mock('@folio/stripes/core', () => ({
 
 describe('Automatic scheduling mutation', () => {
   const contextMock = jest.fn();
-  const wrapper = ({ children }: { children: ReactNode }) =>
-    withIntlConfiguration(
-      <QueryClientProvider client={new QueryClient()}>
-        <CalloutContext.Provider value={{ sendCallout: contextMock }}>{children}</CalloutContext.Provider>
-      </QueryClientProvider>,
-    );
+  const wrapper = ({ children }: { children: ReactNode }) => withIntlConfiguration(
+    <QueryClientProvider client={new QueryClient()}>
+      <CalloutContext.Provider value={{ sendCallout: contextMock }}>{children}</CalloutContext.Provider>
+    </QueryClientProvider>,
+  );
 
   it('handles successful responses', async () => {
     const { result: mutator } = renderHook(() => useManualSchedulerMutation(), {
@@ -34,21 +33,17 @@ describe('Automatic scheduling mutation', () => {
       mutator.current('bursar data' as any);
     });
 
-    await waitFor(() =>
-      expect(kyMock).toHaveBeenLastCalledWith('data-export-spring/jobs', {
-        json: {
-          type: 'BURSAR_FEES_FINES',
-          exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
-        },
-      }),
-    );
+    await waitFor(() => expect(kyMock).toHaveBeenLastCalledWith('data-export-spring/jobs', {
+      json: {
+        type: 'BURSAR_FEES_FINES',
+        exportTypeSpecificParameters: { bursarFeeFines: 'bursar data' },
+      },
+    }));
 
-    await waitFor(() =>
-      expect(contextMock).toHaveBeenLastCalledWith({
-        type: 'success',
-        message: 'Job has been scheduled',
-      }),
-    );
+    await waitFor(() => expect(contextMock).toHaveBeenLastCalledWith({
+      type: 'success',
+      message: 'Job has been scheduled',
+    }));
   });
 
   it('handles error responses', async () => {
@@ -62,22 +57,18 @@ describe('Automatic scheduling mutation', () => {
       mutator.current('bursar data that fails' as any);
     });
 
-    await waitFor(() =>
-      expect(kyMock).toHaveBeenLastCalledWith('data-export-spring/jobs', {
-        json: {
-          type: 'BURSAR_FEES_FINES',
-          exportTypeSpecificParameters: {
-            bursarFeeFines: 'bursar data that fails',
-          },
+    await waitFor(() => expect(kyMock).toHaveBeenLastCalledWith('data-export-spring/jobs', {
+      json: {
+        type: 'BURSAR_FEES_FINES',
+        exportTypeSpecificParameters: {
+          bursarFeeFines: 'bursar data that fails',
         },
-      }),
-    );
+      },
+    }));
 
-    await waitFor(() =>
-      expect(contextMock).toHaveBeenLastCalledWith({
-        type: 'error',
-        message: 'Failed to start job',
-      }),
-    );
+    await waitFor(() => expect(contextMock).toHaveBeenLastCalledWith({
+      type: 'error',
+      message: 'Failed to start job',
+    }));
   });
 });
diff --git a/src/api/mutators/useManualSchedulerMutation.ts b/src/api/mutators/useManualSchedulerMutation.ts
@@ -10,28 +10,25 @@ export default function useManualSchedulerMutation() {
   const intl = useIntl();
 
   const mutation = useMutation(
-    async (parameters: BursarExportJobDTO) =>
-      ky.post('data-export-spring/jobs', {
-        json: {
-          type: 'BURSAR_FEES_FINES',
-          exportTypeSpecificParameters: { bursarFeeFines: parameters },
-        },
-      }),
+    async (parameters: BursarExportJobDTO) => ky.post('data-export-spring/jobs', {
+      json: {
+        type: 'BURSAR_FEES_FINES',
+        exportTypeSpecificParameters: { bursarFeeFines: parameters },
+      },
+    }),
     {
-      onError: () =>
-        context.sendCallout({
-          type: 'error',
-          message: intl.formatMessage({
-            id: 'ui-plugin-bursar-export.bursarExports.scheduler.mutation.manual.error',
-          }),
+      onError: () => context.sendCallout({
+        type: 'error',
+        message: intl.formatMessage({
+          id: 'ui-plugin-bursar-export.bursarExports.scheduler.mutation.manual.error',
         }),
-      onSuccess: () =>
-        context.sendCallout({
-          type: 'success',
-          message: intl.formatMessage({
-            id: 'ui-plugin-bursar-export.bursarExports.scheduler.mutation.manual.success',
-          }),
+      }),
+      onSuccess: () => context.sendCallout({
+        type: 'success',
+        message: intl.formatMessage({
+          id: 'ui-plugin-bursar-export.bursarExports.scheduler.mutation.manual.success',
         }),
+      }),
     },
   );
 

diff --git a/src/api/queries/useCampuses.ts b/src/api/queries/useCampuses.ts
@@ -33,7 +33,6 @@ export default function useCampuses() {
 
   return useQuery<CampusDTO[]>(
     ['ui-plugin-bursar-export', 'campuses'],
-    async () =>
-      (await ky.get(`location-units/campuses?cql.allRecords=1&limit=${MAX_LIMIT}`).json<CampusesResponse>()).loccamps,
+    async () => (await ky.get(`location-units/campuses?cql.allRecords=1&limit=${MAX_LIMIT}`).json<CampusesResponse>()).loccamps,
   );
 }
diff --git a/src/api/queries/useCurrentConfig.ts b/src/api/queries/useCurrentConfig.ts
@@ -12,13 +12,12 @@ export default function useCurrentConfig() {
 
   return useQuery<SavedJobConfiguration | null>(
     ['ui-plugin-bursar-export', 'current-config'],
-    async () =>
-      (
-        await ky
-          .get('data-export-spring/configs', {
-            searchParams: { limit: 1, query: 'type==BURSAR_FEES_FINES' },
-          })
-          .json<CurrentConfigResponse>()
-      ).configs?.[0] ?? null,
+    async () => (
+      await ky
+        .get('data-export-spring/configs', {
+          searchParams: { limit: 1, query: 'type==BURSAR_FEES_FINES' },
+        })
+        .json<CurrentConfigResponse>()
+    ).configs?.[0] ?? null,
   );
 }
diff --git a/src/api/queries/useInstitutions.ts b/src/api/queries/useInstitutions.ts
@@ -31,8 +31,7 @@ export default function useInstitutions() {
 
   return useQuery<InstitutionDTO[]>(
     ['ui-plugin-bursar-export', 'institutions'],
-    async () =>
-      (await ky.get(`location-units/institutions?cql.allRecords=1&limit=${MAX_LIMIT}`).json<InstitutionsResponse>())
-        .locinsts,
+    async () => (await ky.get(`location-units/institutions?cql.allRecords=1&limit=${MAX_LIMIT}`).json<InstitutionsResponse>())
+      .locinsts,
   );
 }
diff --git a/src/api/queries/useLibraries.ts b/src/api/queries/useLibraries.ts
@@ -33,7 +33,6 @@ export default function useLibraries() {
 
   return useQuery<LibraryDTO[]>(
     ['ui-plugin-bursar-export', 'libraries'],
-    async () =>
-      (await ky.get(`location-units/libraries?cql.allRecords=1&limit=${MAX_LIMIT}`).json<LibrariesResponse>()).loclibs,
+    async () => (await ky.get(`location-units/libraries?cql.allRecords=1&limit=${MAX_LIMIT}`).json<LibrariesResponse>()).loclibs,
   );
 }