Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIF-526 Implement action for download allocation worksheet #842

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Nov 29, 2024

Purpose

https://folio-org.atlassian.net/browse/UIF-526

In order to support bulk edit of budgets via CSV upload, a system-generated worksheet in CSV format will help ensure necessary data is transmitted while minimizing the risk of manual error.

Approach

Implement components and hooks that fetch fiscal years and render them as a selection. Use /finance/finance-data endpoint for fetching finance data for the selected fiscal year and ledger or group.

Screenshot

chrome_o5cb75TvrL.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Nov 29, 2024

Jest Unit Test Statistics

    1 files  ±0  176 suites  +4   4m 28s ⏱️ -4s
436 tests +8  430 ✔️ +8  6 💤 ±0  0 ±0 
442 runs  +8  436 ✔️ +8  6 💤 ±0  0 ±0 

Results for commit c9c9938. ± Comparison against base commit 6008f90.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 29, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit c9c9938. ± Comparison against base commit 6008f90.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam merged commit 27e9d9f into master Dec 3, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIF-526 branch December 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants