Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-497: "Are you sure" preview displays outdated values after User changed selection on bulk edit form and clicked "Confirm changes" #626

Closed
wants to merge 8 commits into from

Conversation

UladzislauKutarkin
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIBULKED-497

Here fix logic of calling bulkoperation and preview calls

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team October 25, 2024 14:35
Copy link

github-actions bot commented Oct 25, 2024

Jest Unit Test Statistics

    1 files  ±0    44 suites  ±0   3m 6s ⏱️ -1s
286 tests ±0  286 ✔️ ±0  0 💤 ±0  0 ±0 
293 runs  ±0  293 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 710826e. ± Comparison against base commit ac6c7d9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 25, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 710826e. ± Comparison against base commit ac6c7d9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@NikitaSedyx NikitaSedyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix lint errors

@UladzislauKutarkin
Copy link
Contributor Author

fix lint errors

Fixed

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud


showErrorMessage(response);
useEffect(() => {
if (!shouldRefetch || interval <= 0) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can do this and in come cases return callback for clean up... you even have a linter error

@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-497 branch October 28, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants